🎨 Palette: Add Switch to Core profile recovery actions to empty views - #190
🎨 Palette: Add Switch to Core profile recovery actions to empty views#190WaySoul (SoulWayy) wants to merge 4 commits into
Conversation
Introduces contextual recovery buttons when selected profiles or status filters result in empty states across Server Map, Catalog, and Fabric views. Also updates tests to verify recovery button rendering. Co-authored-by: SoulWayy <285978010+SoulWayy@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
Warning Review limit reached
Next review available in: 53 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughProfile-filtered dashboard empty states now provide “Switch profile to core” recovery actions across route tables, catalog results, and Fabric capabilities. Catalog messages now identify the active profile. Tests verify the rendered recovery action. ChangesProfile recovery actions
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/kater/web/dashboard.py`:
- Around line 4236-4243: Update loadFabricView() to include the current active
profile when requesting /api/capabilities, so the response reflects that profile
instead of defaulting to core. Update switchProfile() to reload the Fabric view
after changing profiles, ensuring the displayed content and empty-state action
reflect the new profile.
In `@tests/test_dashboard.py`:
- Line 88: Breid de dashboardtest rond de assert op “Switch profile to core” uit
met een uitvoerbare DOM- of dashboardinteractie: gebruik een niet-core empty
state, valideer dat daadwerkelijk een button[type="button"].view-empty-link
wordt gerenderd en klik erop om te controleren dat het profiel naar core
wijzigt.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: e96238ba-3901-4deb-af66-8d2ca236c298
📒 Files selected for processing (3)
.Jules/palette.mdsrc/kater/web/dashboard.pytests/test_dashboard.py
| if (activeProfile !== 'core') { | ||
| const btn = document.createElement('button'); | ||
| btn.type = 'button'; | ||
| btn.className = 'view-empty-link'; | ||
| btn.textContent = 'Switch profile to core'; | ||
| btn.onclick = () => switchProfile('core'); | ||
| empty.appendChild(btn); | ||
| } |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift
Geef het profiel door en laad Fabric opnieuw na de actie.
loadFabricView() vraagt op Line 4215 /api/capabilities op zonder profile. src/kater/api/fabric_routes.py valt dan terug op core. De nieuwe lege toestand kan daardoor niet betrouwbaar het actieve profiel tonen.
Daarnaast laadt switchProfile() de Fabric-view niet opnieuw. Na een klik blijft de oude inhoud staan.
Voorgestelde wijziging
async function switchProfile(p) {
...
loadCatalog();
if (currentView === 'catalog') loadCatalogView();
+ if (currentView === 'fabric') loadFabricView();
}
async function loadFabricView() {
...
- api('/api/capabilities'),
+ api('/api/capabilities?profile=' + encodeURIComponent(activeProfile || 'core')),
}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/kater/web/dashboard.py` around lines 4236 - 4243, Update loadFabricView()
to include the current active profile when requesting /api/capabilities, so the
response reflects that profile instead of defaulting to core. Update
switchProfile() to reload the Fabric view after changing profiles, ensuring the
displayed content and empty-state action reflect the new profile.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| empty.appendChild(btn); | ||
| } | ||
| } else { empty.textContent = 'No servers in this profile.'; } | ||
| if (activeProfile !== 'core') { |
There was a problem hiding this comment.
🔥 The Roast: You're hand-crafting buttons here like it's 1995, but two blocks over the Catalog section already has an addLink helper that does the exact same thing. This is like building a bicycle from scratch when there's a perfectly good car parked in the driveway.
🩹 The Fix: Extract the button-creation pattern into a shared helper (or reuse the Catalog's addLink pattern) so all three views stay in sync when the button style evolves.
📏 Severity: suggestion
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| const empty = document.createElement('div'); | ||
| empty.className = 'view-empty'; | ||
| empty.textContent = 'No capabilities discoverable for the current profile.'; | ||
| if (activeProfile !== 'core') { |
There was a problem hiding this comment.
🔥 The Roast: Another hand-built button where the Catalog already handed you the tool. This is the third time you've reinvented the same wheel in this PR — at this rate you'll have your own tire factory by the end of the week.
🩹 The Fix: Reuse the same helper pattern from the Catalog section (or extract one) so the Fabric view's empty-state button stays consistent with the rest of the codebase.
📏 Severity: suggestion
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| # Labels shown in the empty state, plus the shared styling hook. | ||
| assert "Clear search" in html | ||
| assert "Switch filter to all" in html | ||
| assert "Switch profile to core" in html |
There was a problem hiding this comment.
🔥 The Roast: You're testing that the string "Switch profile to core" exists in the HTML, but since activeProfile defaults to 'core', that button would never actually render at runtime. It's like testing that a fire extinguisher exists in the building by checking the blueprint — the extinguisher might as well not exist.
🩹 The Fix: Either set activeProfile to a non-core value in the test and verify the button appears, or test the conditional rendering logic directly instead of just checking for the string in the source.
📏 Severity: suggestion
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
There was a problem hiding this comment.
Already covered: a behavioral Node/DOM test (test_server_map_empty_state_recovery_buttons_behavior_node) was added in a prior commit that sets activeProfile to a non-core value, verifies the button renders, and verifies clicking it switches the profile to core.
Code Review Roast 🔥Verdict: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)
🏆 Best part: The Catalog section's 💀 Worst part: The button creation pattern is duplicated in three places across two files, which means a future style change will require three separate edits instead of one. 📊 Overall: Like a restaurant with three identical menus on every table — the food is fine, but somebody forgot to consolidate the printing. Files Reviewed (3 files)
Fix these issues in Kilo Cloud Previous Review Summary (commit 478975b)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 478975b)Verdict: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)
🏆 Best part: The Catalog section's 💀 Worst part: The button creation pattern is duplicated in three places across two files, which means a future style change will require three separate edits instead of one. 📊 Overall: Like a restaurant with three identical menus on every table — the food is fine, but somebody forgot to consolidate the printing. Files Reviewed (3 files)
Reviewed by ling-3.0-flash:free · Input: 61.3K · Output: 17.5K · Cached: 315.6K |
…tring Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| btn.type = 'button'; | ||
| btn.className = 'view-empty-link'; | ||
| btn.textContent = 'Switch profile to core'; | ||
| btn.onclick = () => switchProfile('core'); |
There was a problem hiding this comment.
When Fabric has rendered this empty state, clicking the recovery action updates the selected profile but does not call loadFabricView(). switchProfile() refreshes Catalog, but has no Fabric-view refresh branch, so the panel continues showing the stale empty-state button and makes no new capability request after the user switches to core. Reload the Fabric view after a profile change while currentView === 'fabric'.
Context Used: Focking gretig zijn en niet stoppen tot perfectie.... (source)
Artifacts
Browserless Fabric profile-switch executable harness
- Executes the extracted dashboard functions against a minimal DOM and mocked Fabric API outcomes, with an in-memory comparison reload only; takeaway: it directly exercises the exact click path without modifying product code.
Fabric empty-capabilities button before reload fix
- Captured output of the repository behavior with an empty `/api/capabilities` payload; takeaway: profile changes to core but Fabric performs no second load and retains the button.
Fabric rejected-capabilities button before reload fix
- Captured output of the repository behavior with `/api/capabilities` rejecting; takeaway: the same click path changes profile but leaves the Fabric panel unchanged.
Fabric empty-capabilities button with simulated reload comparison
- Captured output of an in-memory candidate branch that reloads Fabric after switching profile; takeaway: the second Fabric request removes the stale recovery button.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/kater/web/dashboard.py
Line: 4241
Comment:
**Fabric profile recovery does not refresh the panel**
When Fabric has rendered this empty state, clicking the recovery action updates the selected profile but does not call `loadFabricView()`. `switchProfile()` refreshes Catalog, but has no Fabric-view refresh branch, so the panel continues showing the stale empty-state button and makes no new capability request after the user switches to `core`. Reload the Fabric view after a profile change while `currentView === 'fabric'`.
**Context Used:** Focking gretig zijn en niet stoppen tot perfectie.... ([source](https://app.greptile.com/review/custom-context?memory=instruction-0))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
There was a problem hiding this comment.
Already fixed on the branch: commit e8fbd30 added the if (currentView === 'fabric') loadFabricView(); branch to switchProfile(), so the Fabric panel reloads after the recovery click. The review was against an older snapshot.
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Introduces contextual recovery buttons when selected profiles or status filters result in empty states across Server Map, Catalog, and Fabric views. Also updates tests to verify recovery button rendering. Co-authored-by: SoulWayy <285978010+SoulWayy@users.noreply.github.com>
OnlineChef
left a comment
OnlineChef
left a comment
There was a problem hiding this comment.
Blocking: the Fabric empty-state recovery button still calls only switchProfile('core'). The current branch does not explicitly reload the Fabric panel from this action, so the visible capabilities state can remain stale after switching profiles. Route the profile transition through a Fabric-aware refresh or make switchProfile call loadFabricView() when currentView === 'fabric', and cover both empty-response and rejected-request recovery paths.
2 participants
💡 What:
Added contextual recovery buttons/links (
Switch profile to coreusing semantic<button type="button">with class.view-empty-link) to empty views in the Server Map, Catalog, and Fabric dashboard sections when the active profile is not'core'.🎯 Why:
Prevent users (especially keyboard and screen-reader users) from hitting annoying visual and functional dead ends when custom profiles or combined filters return no results.
📸 Before/After:
♿ Accessibility:
Ensured semantic
<button type="button">elements are used with keyboard accessibility, proper labels, and sequential focus order, fully tested via Playwright.PR created automatically by Jules for task 4802806421746281431 started by WaySoul (@SoulWayy)
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.Greptile Summary
This change adds “Switch profile to core” recovery actions to empty Server Map, Catalog, and Fabric states, plus coverage and documentation for the pattern.
The Fabric recovery action was exercised with both an empty capabilities response and a rejected capabilities request. It updates the active profile to
core, but the Fabric panel is not reloaded, so the stale empty state remains visible until another refresh occurs.Confidence Score: 4/5
Not merge-safe until the Fabric profile recovery action reloads the Fabric view.
The review found one verified P1 behavior defect. The selected profile is retained correctly, but the visible Fabric results remain stale after using the new recovery control.
Files Needing Attention: src/kater/web/dashboard.py
What T-Rex did
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "🎨 Palette: Add Switch to Core profile r..." | Re-trigger Greptile
Context used: